Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unsupported Python 2.6 from configure #27381

Closed
wants to merge 2 commits into from
Closed

Remove the unsupported Python 2.6 from configure #27381

wants to merge 2 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 24, 2019

A precursor to #25878

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 24, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22678/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2019 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/22829/ ✅

@Trott
Copy link
Member

Trott commented Apr 30, 2019

Landed in 56098a9

@Trott Trott closed this Apr 30, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 30, 2019
@cclauss @Trott
build: remove unsupported Python 2.6 from configure
56098a9 
PR-URL: nodejs#27381
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cclauss cclauss deleted the patch-3 branch April 30, 2019 21:52
targos pushed a commit that referenced this pull request May 4, 2019
@cclauss @targos
build: remove unsupported Python 2.6 from configure
67205f5 
PR-URL: #27381
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cclauss @nodejs-github-bot @Trott @targos @cjihrig @richardlau @BethGriggs @BridgeAR